feat: add x1 portable_simd type aliases (f32x1, ...) and implementations of the corresponding traits
#67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabizri
changed the title
f32x1, ...) and implementations of the corresponding traits
Contributor
Author
|
Pinging @sebcrozet : do you need more work on this PR or do you think it's mergeable as-is ? Thanks |
Contributor
Author
|
Another ping @sebcrozet, thanks |
Member
|
Looking good, thank you! And thank you for the pings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now they were not implemented, even though they are in rust nightly's
core::simd. Besides creating an arbitrary limitation, this practically makes it more complicated & ugly to have lane-count generic code, as we cannot scale down to single-lane operations.